[rllib] Cleanup BUILD.bazel and rllib.rayci.yml
#59388
Conversation
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request provides a much-needed cleanup of the test tags in rllib/BUILD.bazel and the CI configuration in .buildkite/rllib.rayci.yml. The changes significantly improve maintainability by simplifying the tagging scheme and making the CI steps more explicit and organized. The large-scale removal of unused and confusing tags in BUILD.bazel is a great improvement. My review identified one potential issue in the CI configuration that might unintentionally alter the set of tests being run, contrary to the PR's stated goal. A suggestion has been provided to address this. Overall, this is a valuable cleanup effort.
pseudo-rnd-thoughts
changed the title
BUILD.bazel and rllib.rayci.yml
Signed-off-by: Mark Towers <mark@anyscale.com>
|
@simonsays1980 Do you plan to use I see that |
kamil-kaczmarek
left a comment
kamil-kaczmarek
left a comment
There was a problem hiding this comment.
Left few comments.
Signed-off-by: Mark Towers <mark@anyscale.com>
@kamil-kaczmarek (cc. @pseudo-rnd-thoughts ) I have never personally used this tag. So I think its safe to remove it. |
Signed-off-by: Mark Towers <mark@anyscale.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
# Conflicts: # rllib/BUILD.bazel
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
|
Notably this clean up removes following tags from BUILD.bazel:
|
Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com>
kamil-kaczmarek
left a comment
kamil-kaczmarek
left a comment
There was a problem hiding this comment.
LGTM! Great work
## Description RLlib's rayci.yml [file](https://github.com/ray-project/ray/blob/master/.buildkite/rllib.rayci.yml) and the BUILD.bazel [file](https://github.com/ray-project/ray/blob/master/rllib/BUILD.bazel) are disconnected such that there are old tags in the BUILD not the rayci and vice-versa. This PR attempts to clean up both files without modifying what tests are or aren't run currently --------- Signed-off-by: Mark Towers <mark@anyscale.com> Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com> Co-authored-by: Mark Towers <mark@anyscale.com> Co-authored-by: Kamil Kaczmarek <kamil@anyscale.com>
## Description RLlib's rayci.yml [file](https://github.com/ray-project/ray/blob/master/.buildkite/rllib.rayci.yml) and the BUILD.bazel [file](https://github.com/ray-project/ray/blob/master/rllib/BUILD.bazel) are disconnected such that there are old tags in the BUILD not the rayci and vice-versa. This PR attempts to clean up both files without modifying what tests are or aren't run currently --------- Signed-off-by: Mark Towers <mark@anyscale.com> Signed-off-by: Kamil Kaczmarek <kamil@anyscale.com> Co-authored-by: Mark Towers <mark@anyscale.com> Co-authored-by: Kamil Kaczmarek <kamil@anyscale.com> Signed-off-by: jeffery4011 <jefferyshen1015@gmail.com>
4 participants
Description
RLlib's rayci.yml file and the BUILD.bazel file are disconnected such that there are old tags in the BUILD not the rayci and vice-versa.
This PR attempts to clean up both files without modifying what tests are or aren't run currently